fix: workspace home model count submenus showing for every model on open#569
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9615e72e74
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
johnny4dev
force-pushed
the
fix/worktree-model-menu-submenu-layout
branch
from
9615e72 to
ad13659
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad136592a6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
johnny4dev
force-pushed
the
fix/worktree-model-menu-submenu-layout
branch
from
ad13659 to
20873a8
Compare
johnny4dev
force-pushed
the
fix/worktree-model-menu-submenu-layout
branch
from
20873a8 to
e9519a9
Compare
Dimillian
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcd6a455d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .workspace-home-model-option .workspace-home-model-toggle { | ||
| width: 175px; | ||
| flex: 1; | ||
| justify-content: space-between; | ||
| min-width: 175px; | ||
| width: 100%; | ||
| flex: 1 1 auto; | ||
| padding-right: 48px; |
There was a problem hiding this comment.
WorkspaceHomeRunControls.tsx:203-227 only renders the 1x/submenu affordance when runMode === "worktree", but this new padding-right: 48px applies to every .workspace-home-model-toggle. In local mode that leaves an empty gutter on each row and, because the popover now sizes to max-content, makes long model names clip or overflow about 48px sooner even though there is no count control to make room for. This is a visible regression for local-only workspaces with longer provider/model labels.
Useful? React with 👍 / 👎.
2 participants
Summary
Fix workspace home model count submenus showing for every model on open.
While fixing that, this also cleans up the worktree model menu layout so long model names remain readable and no longer collide with the instance count affordance on the right.
Details
In worktree mode, each model row has a nested submenu for selecting the number of runs. The submenu should stay hidden until the user hovers or focuses the corresponding model row.
This change updates the menu styling so:
1xand chevron keep dedicated spacing without overlapping labelsScreenshots
Before:
After:
Scope
src/styles/workspace-home.cssValidation
npm run typechecknpm run test